Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Fixes #63
master
that I also fixed. They were referring to various domains, so I pointed them to a "neutral" one - mockapi.io. I have no affiliation with them.assert x==y
→assert_equal x, y
Set-Cookie
header. (See test_net_http_hacked and test_http_full_request_headers fail #63)HTTP headers are case insensitive, but
Rack::MockResponse
is callingheaders.fetch
which isn't case insensitive even whenheaders
is aUtils::HeaderHash
instance. The easiest solution seemed to be to just change our normalized header format to whateverRack::MockResponse
expects.